Add jquery & materialize js

parent 1fce9c0b
......@@ -18,6 +18,8 @@
{% block css %}{% endblock %}
<script defer src="https://use.fontawesome.com/releases/v5.0.6/js/all.js"></script>
<script defer src="https://code.jquery.com/jquery-3.3.1.min.js" integrity="sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=" crossorigin="anonymous"></script>
  • This is not a good idea IMO as we shouldn't expect that people connecting to eistiens.net from the internal EISTI network have their proxy enabled.

    Using something like yarn would fix this kind of problem and maybe allow a cleaner management of the project JS libraries.

    Edited by Clément AUBIN
  • Could you please tell me how you came to this conclusion? What's you're saying makes no sense at all.

    We're talking of a deferred loading of jQuery necessary for the materialize's js.

  • @Valz I've updated my original comment, you might understand the problem better now.

  • Using sources coming from CDNs that are external to an organization internal network is generally a bad idea as you cannot expect someone that uses your product to have a working external network access.

    In order to work around this issue, OSS projects usually rely on JS dependencies managers, such as Yarn, npm or simply copy the JS dependencies they rely on on their server.

  • Ah, I see what you mean. For now, we don't care. That will be a topic when the platform will be ready to be used.

  • Created https://phabricator.atilla.org/T76 so that you don't forget :)

Please register or sign in to reply
<script defer src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.100.2/js/materialize.min.js"></script>
</head>
<body class="grey lighten-3">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment